361 lines
11 KiB
PHP
361 lines
11 KiB
PHP
|
<?php
|
||
|
|
||
|
/*
|
||
|
* This file is part of the Symfony package.
|
||
|
*
|
||
|
* (c) Fabien Potencier <fabien@symfony.com>
|
||
|
*
|
||
|
* For the full copyright and license information, please view the LICENSE
|
||
|
* file that was distributed with this source code.
|
||
|
*/
|
||
|
|
||
|
namespace Symfony\Component\DependencyInjection\Tests\Compiler;
|
||
|
|
||
|
use PHPUnit\Framework\TestCase;
|
||
|
use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
|
||
|
use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
|
||
|
use Symfony\Component\DependencyInjection\Compiler\AnalyzeServiceReferencesPass;
|
||
|
use Symfony\Component\DependencyInjection\Compiler\InlineServiceDefinitionsPass;
|
||
|
use Symfony\Component\DependencyInjection\ContainerBuilder;
|
||
|
use Symfony\Component\DependencyInjection\Definition;
|
||
|
use Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException;
|
||
|
use Symfony\Component\DependencyInjection\Reference;
|
||
|
|
||
|
class InlineServiceDefinitionsPassTest extends TestCase
|
||
|
{
|
||
|
public function testProcess()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$inlineable = $container
|
||
|
->register('inlinable.service')
|
||
|
->setPublic(false)
|
||
|
;
|
||
|
|
||
|
$container
|
||
|
->register('service')
|
||
|
->setArguments([new Reference('inlinable.service')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$arguments = $container->getDefinition('service')->getArguments();
|
||
|
$this->assertInstanceOf(Definition::class, $arguments[0]);
|
||
|
$this->assertSame($inlineable, $arguments[0]);
|
||
|
$this->assertFalse($container->has('inlinable.service'));
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlinesWhenAliasedServiceIsShared()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setPublic(false)
|
||
|
;
|
||
|
$container->setAlias('moo', 'foo');
|
||
|
|
||
|
$container
|
||
|
->register('service')
|
||
|
->setArguments([$ref = new Reference('foo')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$arguments = $container->getDefinition('service')->getArguments();
|
||
|
$this->assertSame($ref, $arguments[0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesInlineNonSharedService()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setShared(false)
|
||
|
;
|
||
|
$bar = $container
|
||
|
->register('bar')
|
||
|
->setPublic(false)
|
||
|
->setShared(false)
|
||
|
;
|
||
|
$container->setAlias('moo', 'bar');
|
||
|
|
||
|
$container
|
||
|
->register('service')
|
||
|
->setArguments([new Reference('foo'), $ref = new Reference('moo'), new Reference('bar')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$arguments = $container->getDefinition('service')->getArguments();
|
||
|
$this->assertEquals($container->getDefinition('foo'), $arguments[0]);
|
||
|
$this->assertNotSame($container->getDefinition('foo'), $arguments[0]);
|
||
|
$this->assertSame($ref, $arguments[1]);
|
||
|
$this->assertEquals($bar, $arguments[2]);
|
||
|
$this->assertNotSame($bar, $arguments[2]);
|
||
|
$this->assertFalse($container->has('bar'));
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlineMixedServicesLoop()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->addArgument(new Reference('bar'))
|
||
|
->setShared(false)
|
||
|
;
|
||
|
$container
|
||
|
->register('bar')
|
||
|
->setPublic(false)
|
||
|
->addMethodCall('setFoo', [new Reference('foo')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$this->assertEquals(new Reference('bar'), $container->getDefinition('foo')->getArgument(0));
|
||
|
}
|
||
|
|
||
|
public function testProcessThrowsOnNonSharedLoops()
|
||
|
{
|
||
|
$this->expectException(ServiceCircularReferenceException::class);
|
||
|
$this->expectExceptionMessage('Circular reference detected for service "bar", path: "bar -> foo -> bar".');
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->addArgument(new Reference('bar'))
|
||
|
->setShared(false)
|
||
|
;
|
||
|
$container
|
||
|
->register('bar')
|
||
|
->setShared(false)
|
||
|
->addMethodCall('setFoo', [new Reference('foo')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
}
|
||
|
|
||
|
public function testProcessNestedNonSharedServices()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->addArgument(new Reference('bar1'))
|
||
|
->addArgument(new Reference('bar2'))
|
||
|
;
|
||
|
$container
|
||
|
->register('bar1')
|
||
|
->setShared(false)
|
||
|
->addArgument(new Reference('baz'))
|
||
|
;
|
||
|
$container
|
||
|
->register('bar2')
|
||
|
->setShared(false)
|
||
|
->addArgument(new Reference('baz'))
|
||
|
;
|
||
|
$container
|
||
|
->register('baz')
|
||
|
->setShared(false)
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$baz1 = $container->getDefinition('foo')->getArgument(0)->getArgument(0);
|
||
|
$baz2 = $container->getDefinition('foo')->getArgument(1)->getArgument(0);
|
||
|
|
||
|
$this->assertEquals($container->getDefinition('baz'), $baz1);
|
||
|
$this->assertEquals($container->getDefinition('baz'), $baz2);
|
||
|
$this->assertNotSame($baz1, $baz2);
|
||
|
}
|
||
|
|
||
|
public function testProcessInlinesIfMultipleReferencesButAllFromTheSameDefinition()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
|
||
|
$a = $container->register('a')->setPublic(false);
|
||
|
$b = $container
|
||
|
->register('b')
|
||
|
->addArgument(new Reference('a'))
|
||
|
->addArgument(new Definition(null, [new Reference('a')]))
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$arguments = $b->getArguments();
|
||
|
$this->assertSame($a, $arguments[0]);
|
||
|
|
||
|
$inlinedArguments = $arguments[1]->getArguments();
|
||
|
$this->assertSame($a, $inlinedArguments[0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessInlinesPrivateFactoryReference()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
|
||
|
$container->register('a')->setPublic(false);
|
||
|
$b = $container
|
||
|
->register('b')
|
||
|
->setPublic(false)
|
||
|
->setFactory([new Reference('a'), 'a'])
|
||
|
;
|
||
|
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setArguments([
|
||
|
$ref = new Reference('b'),
|
||
|
]);
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$inlinedArguments = $container->getDefinition('foo')->getArguments();
|
||
|
$this->assertSame($b, $inlinedArguments[0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlinePrivateFactoryIfReferencedMultipleTimesWithinTheSameDefinition()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('a')
|
||
|
;
|
||
|
$container
|
||
|
->register('b')
|
||
|
->setPublic(false)
|
||
|
->setFactory([new Reference('a'), 'a'])
|
||
|
;
|
||
|
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setArguments([
|
||
|
$ref1 = new Reference('b'),
|
||
|
$ref2 = new Reference('b'),
|
||
|
])
|
||
|
;
|
||
|
$this->process($container);
|
||
|
|
||
|
$args = $container->getDefinition('foo')->getArguments();
|
||
|
$this->assertSame($ref1, $args[0]);
|
||
|
$this->assertSame($ref2, $args[1]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlineReferenceWhenUsedByInlineFactory()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('a')
|
||
|
;
|
||
|
$container
|
||
|
->register('b')
|
||
|
->setPublic(false)
|
||
|
->setFactory([new Reference('a'), 'a'])
|
||
|
;
|
||
|
|
||
|
$inlineFactory = new Definition();
|
||
|
$inlineFactory->setPublic(false);
|
||
|
$inlineFactory->setFactory([new Reference('b'), 'b']);
|
||
|
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setArguments([
|
||
|
$ref = new Reference('b'),
|
||
|
$inlineFactory,
|
||
|
])
|
||
|
;
|
||
|
$this->process($container);
|
||
|
|
||
|
$args = $container->getDefinition('foo')->getArguments();
|
||
|
$this->assertSame($ref, $args[0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlineWhenServiceIsPrivateButLazy()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setPublic(false)
|
||
|
->setLazy(true)
|
||
|
;
|
||
|
|
||
|
$container
|
||
|
->register('service')
|
||
|
->setArguments([$ref = new Reference('foo')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$arguments = $container->getDefinition('service')->getArguments();
|
||
|
$this->assertSame($ref, $arguments[0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotInlineWhenServiceReferencesItself()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('foo')
|
||
|
->setPublic(false)
|
||
|
->addMethodCall('foo', [$ref = new Reference('foo')])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$calls = $container->getDefinition('foo')->getMethodCalls();
|
||
|
$this->assertSame($ref, $calls[0][1][0]);
|
||
|
}
|
||
|
|
||
|
public function testProcessDoesNotSetLazyArgumentValuesAfterInlining()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container
|
||
|
->register('inline')
|
||
|
->setShared(false)
|
||
|
;
|
||
|
$container
|
||
|
->register('service-closure')
|
||
|
->setArguments([new ServiceClosureArgument(new Reference('inline'))])
|
||
|
;
|
||
|
$container
|
||
|
->register('iterator')
|
||
|
->setArguments([new IteratorArgument([new Reference('inline')])])
|
||
|
;
|
||
|
|
||
|
$this->process($container);
|
||
|
|
||
|
$values = $container->getDefinition('service-closure')->getArgument(0)->getValues();
|
||
|
$this->assertInstanceOf(Reference::class, $values[0]);
|
||
|
$this->assertSame('inline', (string) $values[0]);
|
||
|
|
||
|
$values = $container->getDefinition('iterator')->getArgument(0)->getValues();
|
||
|
$this->assertInstanceOf(Reference::class, $values[0]);
|
||
|
$this->assertSame('inline', (string) $values[0]);
|
||
|
}
|
||
|
|
||
|
public function testDoNotInline()
|
||
|
{
|
||
|
$container = new ContainerBuilder();
|
||
|
$container->register('decorated1', 'decorated1')->addTag('container.do_not_inline');
|
||
|
$container->register('decorated2', 'decorated2')->addTag('container.do_not_inline');
|
||
|
$container->setAlias('alias2', 'decorated2');
|
||
|
|
||
|
$container
|
||
|
->register('s1', 's1')
|
||
|
->setDecoratedService('decorated1')
|
||
|
->setPublic(true)
|
||
|
->setProperties(['inner' => new Reference('s1.inner')]);
|
||
|
|
||
|
$container
|
||
|
->register('s2', 's2')
|
||
|
->setDecoratedService('alias2')
|
||
|
->setPublic(true)
|
||
|
->setProperties(['inner' => new Reference('s2.inner')]);
|
||
|
|
||
|
$container->compile();
|
||
|
|
||
|
$this->assertFalse($container->hasAlias('alias2'));
|
||
|
$this->assertEquals(new Reference('decorated2'), $container->getDefinition('s2')->getProperties()['inner']);
|
||
|
$this->assertEquals(new Reference('s1.inner'), $container->getDefinition('s1')->getProperties()['inner']);
|
||
|
$this->assertSame('decorated2', $container->getDefinition('decorated2')->getClass());
|
||
|
$this->assertSame('decorated1', $container->getDefinition('s1.inner')->getClass());
|
||
|
}
|
||
|
|
||
|
protected function process(ContainerBuilder $container)
|
||
|
{
|
||
|
(new InlineServiceDefinitionsPass(new AnalyzeServiceReferencesPass()))->process($container);
|
||
|
}
|
||
|
}
|